Mir

Code review comment for lp://staging/~robertcarr/mir/disable-sequences-and-add-terminate-handler

Revision history for this message
Robert Ancell (robert-ancell) wrote :

The name disable_control_sequences() seems confusing - this is just setting the console into raw mode right? Shouldn't it be called set_raw_mode() or similar?

Is there an easy way for the demo shell to note that it can only be quit using alt+ctrl+backspace? This is likely to confuse people using this.

This change is going to affect all shells, not just the demo shell. It might be worth putting alt+ctrl+backspace into libmirserver by default (at least for now) so other shells also are quittable if we disable input.

Finally, check with Alexandros but I think there was some issues that meant he hadn't enabled raw input yet.

« Back to merge proposal