Software Updater

Merge lp://staging/~robert-ancell/update-manager/ua into lp://staging/update-manager

  1. ua
  2. Merge into main
Proposed by Robert Ancell
Status: Merged
Approved by: Robert Ancell
Approved revision: 2960
Merged at revision: 2950
Proposed branch: lp://staging/~robert-ancell/update-manager/ua
Merge into: lp://staging/update-manager
Diff against target: 328 lines (+97/-18)
4 files modified
UpdateManager/Core/UpdateList.py (+45/-13)
UpdateManager/UpdateManager.py (+26/-1)
UpdateManager/UpdatesAvailable.py (+20/-4)
debian/changelog (+6/-0)
To merge this branch: bzr merge lp://staging/~robert-ancell/update-manager/ua
Reviewer Review Type Date Requested Status
Julian Andres Klode Approve
Review via email: mp+430517@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Julian Andres Klode (juliank) wrote :

It's an interesting proof of concept, but I'd really like to see this done properly by investigating the cache to find out the Pro packages and then using the real Version objects vs. a query in a subprocess, see update-notifier's apt_check.py for example.

Then we also get the description and everything working correctly.

review: Needs Fixing
Revision history for this message
Julian Andres Klode (juliank) :
Revision history for this message
Julian Andres Klode (juliank) wrote :

Though tbh, we probably should ship a python library in ubuntu-advantage-tools and use that in update-notifier and update-manager rather than implement the logic in a third place, but consolidation is not a blocker.

lp://staging/~robert-ancell/update-manager/ua updated
2959. By Robert Ancell

Remove unused code

2960. By Robert Ancell

Use json.load instead of json.loads

Revision history for this message
Robert Ancell (robert-ancell) wrote :

I've fixed the small issues you pointed out.

As you discussed with Seb, we wont be able to access the cache directly in the timeframe required so this will have to be the current solution, right?

Revision history for this message
Julian Andres Klode (juliank) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: