Merge lp://staging/~robert-ancell/quickly/drop-lpi into lp://staging/quickly
Proposed by
Robert Ancell
Status: | Merged |
---|---|
Approved by: | Didier Roche-Tolomelli |
Approved revision: | 668 |
Merged at revision: | 684 |
Proposed branch: | lp://staging/~robert-ancell/quickly/drop-lpi |
Merge into: | lp://staging/quickly |
Diff against target: |
541 lines (+0/-395) 6 files modified
data/templates/ubuntu-application/internal/apportutils.py (+0/-57) data/templates/ubuntu-application/project_root/python_lib/Window.py (+0/-11) data/templates/ubuntu-application/test/apport/TestProjectWindow.py.no_lpi (+0/-102) data/templates/ubuntu-application/test/apport/apport.sh (+0/-84) data/templates/ubuntu-application/test/apportutils.py (+0/-140) data/templates/ubuntu-application/upgrade.py (+0/-1) |
To merge this branch: | bzr merge lp://staging/~robert-ancell/quickly/drop-lpi |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Didier Roche-Tolomelli | Needs Fixing | ||
Review via email: mp+105735@code.staging.launchpad.net |
Description of the change
Remove Launchpad integration. It will be removed in Quantal:
https:/
Not sure if this branch does enough, and also the packaging needs to be updated to drop the dependency.
To post a comment you must log in.
that looks good. Nice work Robert!
I think you did all what is needed apart from giving an upgrade story. ubuntu- application/ upgrade. py to remove it (if the stenza is found) on project upgrade?
Can you try to add an upgrade path to data/templates/
You should "just" need to remove bump the version of the template and remove the lpi lines if you find them anywhere on the project directory.