Code review comment for lp://staging/~robert-ancell/indicator-session/blank-username
Revision history for this message
| Robert Ancell (robert-ancell) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
9199653
demo site
(Get the code!)
I had a long look at what it takes to parse it as UTF-8, I'm not sure if it's worth the effort.
- We really can't be sure it is valid UTF-8 so we have to validate it at the top of the function
- We have to handle invalid UTF8 cases which makes the code more complex
- This only helps if there are only some obscure non-printable UTF8 characters used - it's completely valid to check for the ASCII characters as all the UTF8 will be ignored
So I'd say "don't bother", what do you think?