Code review comment for lp://staging/~roadmr/checkbox/1183271-missing-plugins-in-potfiles

+1

On Thu, May 23, 2013 at 5:35 PM, Daniel Manrique <
<email address hidden>> wrote:

> Daniel Manrique has proposed merging
> lp:~roadmr/checkbox/1183271-missing-plugins-in-potfiles into lp:checkbox.
>
> Commit message:
> Added some missing plugins to POTFILES.in, so their strings can be
> translated.
>
> Requested reviews:
> Checkbox Developers (checkbox-dev)
> Related bugs:
> Bug #1183271 in checkbox: "Checkbox: gksu password prompt not
> translatable"
> https://bugs.launchpad.net/checkbox/+bug/1183271
>
> For more details, see:
>
> https://code.launchpad.net/~roadmr/checkbox/1183271-missing-plugins-in-potfiles/+merge/165422
>
> Added some missing plugins to POTFILES.in, so their strings can be
> translated.
>
> I also took the opportunity to sort the plugin names in POTFILES.in so
> they look nicer.
> --
>
> https://code.launchpad.net/~roadmr/checkbox/1183271-missing-plugins-in-potfiles/+merge/165422
> Your team Checkbox Developers is requested to review the proposed merge of
> lp:~roadmr/checkbox/1183271-missing-plugins-in-potfiles into lp:checkbox.
>
> === modified file 'debian/changelog'
> --- debian/changelog 2013-05-21 15:54:28 +0000
> +++ debian/changelog 2013-05-23 15:34:26 +0000
> @@ -8,6 +8,8 @@
> [ Daniel Manrique ]
> * Expanded optical_drive resource command so it correctly handles
> systems
> with no optical drive (LP: #1182489)
> + * Added missing plugin files to po/POTFILES.in so their strings are
> + translatable (LP: #1183271)
>
> -- Brendan Donegan <email address hidden> Fri, 17 May 2013
> 07:58:29 +0100
>
>
> === modified file 'po/POTFILES.in'
> --- po/POTFILES.in 2013-04-16 16:07:55 +0000
> +++ po/POTFILES.in 2013-05-23 15:34:26 +0000
> @@ -54,13 +54,16 @@
> checkbox_urwid/urwid_interface.py
> checkbox_gtk/gtk_interface.py
> checkbox/user_interface.py
> +plugins/backend_info.py
> plugins/final_prompt.py
> plugins/gather_prompt.py
> plugins/intro_prompt.py
> +plugins/jobs_info.py
> plugins/launchpad_exchange.py
> plugins/launchpad_prompt.py
> plugins/launchpad_report.py
> plugins/lock_prompt.py
> +plugins/message_info.py
> plugins/recover_prompt.py
> plugins/report_prompt.py
> plugins/shell_test.py
>
>
>