Code review comment for lp://staging/~ris/ubuntu/maverick/empathy/fix-538963

Revision history for this message
Artur Rona (ari-tczew) wrote :

Thank you for your time and efforts making Ubuntu better! However, there are some issues:

1) New patches should be accepted upstream first.

2) You did the change on wrong branch. Please resubmit against lp:ubuntu/maverick-proposed/empathy

3) Please use patch system which exist already and it's quilt. You can check it by script 'what-patch' from package ubuntu-dev-tools. Please use DEP3 tags as well.
https://wiki.ubuntu.com/PackagingGuide/PatchSystems

4) Please use version (2.32.1-0ubuntu1.2) maverick-proposed;
https://wiki.ubuntu.com/StableReleaseUpdates

review: Needs Fixing

« Back to merge proposal