Code review comment for lp://staging/~rharding/python-jujuclient/adjust_constraint_handling

Revision history for this message
Benji York (benji) wrote :

Line 49 of the diff has the last two characters on the line transposed ("test.s").

Since we don't really use the type of the constraints unless it is "int", perhaps a boolean instead of "int"/"str" would be more direct.

On line 178 and line 212 of the diff you could use mock.assert_called_once_with(...) instead.

« Back to merge proposal