Code review comment for lp://staging/~raof/qtmir/multi-bufferstream-support

Revision history for this message
Chris Halse Rogers (raof) wrote :

> > > > + root->removeChildNode(root->firstChild());
> > > > I suspect this is leaking nodes
> > >
> > > Hey Gerry. I don't think so because QSGNodes have the OwnedByParent flag
> set
> > > at creation which makes the destruction recursive.
> >
> > Looking at QSGNode::removeChildNode(QSGNode *node) source, I don't see any
> > delete call, and it unparents the node. http://pastebin.ubuntu.com/13008194/
>
> Right! The destruction is recursive, but the removal doesn't delete. So yes,
> the child must be delted after the removal.

Well that's super-unintuitive behaviour!

« Back to merge proposal