Code review comment for lp://staging/~raof/qtmir/multi-bufferstream-support

Revision history for this message
Gerry Boland (gerboland) wrote :

> > + root->removeChildNode(root->firstChild());
> > I suspect this is leaking nodes
>
> Hey Gerry. I don't think so because QSGNodes have the OwnedByParent flag set
> at creation which makes the destruction recursive.

Looking at QSGNode::removeChildNode(QSGNode *node) source, I don't see any delete call, and it unparents the node. http://pastebin.ubuntu.com/13008194/

« Back to merge proposal