lp://staging/~raharper/curtin/trunk.apt-config-validate

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp://staging/~curtin-dev/curtin/trunk

Server Team CI bot: Approve (continuous-integration) on 2017-03-07

curtin developers: Pending requested 2016-08-18

Diff: 125 lines (+54/-7)

2 files modified

curtin/commands/apt_config.py (+25/-7)
tests/unittests/test_apt_source.py (+29/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1613277: Curtin stacktraces when invalid curtin config is provided.

Medium

In Progress

Link a bug report

Related blueprints

419. By Ryan Harper on 2016-08-15

fix formatting

418. By Ryan Harper on 2016-08-15

curtin.apt_config: configure log for subcommand usage

417. By Ryan Harper on 2016-08-15

curtin.apt-config: Add some type checking for common input mistakes

The curtin apt-config format requires some specific types. Assert those
types while processing and raise exceptions if found.

416. By Scott Moser on 2016-08-08

Fix the unittests for test_apt_source.

The tests were written to use 'assert_called', which is only available
in mock versions 2.0. Because of this, the failure would only occur
in releases less than yakkety and not in 'tox'.

415. By Scott Moser on 2016-08-05

get CURTIN_VMTEST_PARALLEL shown correctly in jenkins-runner output

CURTIN_VMTEST_PARALLEL was not getting shown correctly unless it
was set in the environment. This will display it to the effective
value of the environment or --parallel flag.

Also, change some quoting that vim highlighting didn't like.

414. By Scott Moser on 2016-08-05

fix vmtest check_file_strippedline to strip lines before comparing

My addition of load_collect_file and making check_file_strippedline use it
caused errors. This actually strips the lines now before the comparison.

413. By Scott Moser on 2016-08-05

fix whitespace damage in tests/vmtests/__init__.py

revno 412 introduced some whitespace damage.

412. By Scott Moser on 2016-08-05

fix dpkg-reconfigure when debconf_selections was provided.

When debconf selections were provided dpkg-reconfigure was
not being called correctly.

This re-works apply_debconf_selections to be more testable
and adds tests it and new functions that were split out:
 debconf_set_selections
 dpkg_reconfigure

It also changes a vmtest to excercise this path.

411. By Scott Moser on 2016-08-03

fix apt tests on non-intel arch

The apt config tests were failing
a.) on non-amd64 arch because util.get_architecture() wasnt correctly
    mocked.
b.) arbitrarily based on test order.
   the change curtin/commands/apt_config.py is made because
   the test was modifying the return value and inadvertantly modifying
   the persistent (across test) files.

there are a few other test improvements here, mostly in line formating.

410. By Scott Moser on 2016-08-02

Add apt features to curtin.

This allows user more control over what sources are configured in
curtin installation. Examples are various apt configurations, proxies,
mirrors, ppa's, sources.list content and pgp keys trusted by apt.

See examples/apt-source.yaml for examples and explanation of the individual
capabilities.

Along the actual features a huge list of related unit- and vm-tests is added.