Merge ~racb/git-ubuntu:staging-branches into git-ubuntu:main

Proposed by Robie Basak
Status: Needs review
Proposed branch: ~racb/git-ubuntu:staging-branches
Merge into: git-ubuntu:main
Diff against target: 257 lines (+231/-0)
2 files modified
gitubuntu/importer.py (+102/-0)
gitubuntu/importer_test.py (+129/-0)
Reviewer Review Type Date Requested Status
Andreas Hasenack Approve
Server Team CI bot continuous-integration Approve
Canonical Server Reporter Pending
Review via email: mp+451477@code.staging.launchpad.net

Commit message

Make Jenkins happy

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:f25d6fc9b4316c06d3ada43633a32ba87cce2326
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/40/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/40//rebuild

review: Approve (continuous-integration)
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I'm going over the spec and this branch.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Ok, got through the main update_staging_branches(). Overview:
- this function is called after devel (tip) was already updated via update_devel_branches(). If that fails, try/except around _main_with_repo() catches it, and just closes the repo and exits.
- if there is no tip, don't create the staging branch
- only stable series, as defined by LP ("supported")
- if there is no staging ref, create it pointing at tip
- if there is a staging ref, and it points to tip currently, skip (nothing to do)
- if there is a staging ref, and it can be fast-forwarded to tip, do it. If not, log the fact, and continue

Tomorrow morning I'll look at the tests

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

In the jenkins run, we see:
gitubuntu/importer_test.py ............................................. [ 46%]
....xx.................................................................. [ 61%]
...

And at the end:
gitubuntu/importer_test.py 411 2 99%

That's two "misses", what does that mean? This is in the test file this MP is adding tests to.

Revision history for this message
Robie Basak (racb) wrote :

On Wed, Oct 11, 2023 at 12:51:32PM -0000, Andreas Hasenack wrote:
> That's two "misses", what does that mean? This is in the test file this MP is adding tests to.

These are xfails - we have tests for some applied import related
behaviour that haven't yet been fixed (I've not focused on applied
importer behaviour yet). These tests are marked with @pytest.mark.xfail.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Ok, I have nothing further to add. The test seem to cover what is being added, and the changes match the spec. +1

review: Approve
Revision history for this message
Robie Basak (racb) wrote :

Thank you!

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches