git-ubuntu

Merge ~racb/git-ubuntu:changelog-date-edge-cases into git-ubuntu:main

Proposed by Robie Basak on 2022-10-13

Status:	Merged
Approved by:	Robie Basak on 2022-11-18
Approved revision:	f24300f657a413c91be9c222478a0bb9498d380d
Merged at revision:	66cd050ce92c1a0960a22aae0336f0165a6e468c
Proposed branch:	~racb/git-ubuntu:changelog-date-edge-cases
Merge into:	git-ubuntu:main
Diff against target:	75 lines (+38/-7) 2 files modified gitubuntu/git_repository.py (+27/-7) gitubuntu/git_repository_test.py (+11/-0)
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Server Team CI bot	continuous-integration		Approve on 2023-01-18
Bryce Harrington			Approve on 2022-10-13
Canonical Server Reporter		2022-10-13	Pending
Review via email: mp+431516@code.staging.launchpad.net

Commit message

Make Jenkins happy

Revision history for this message

Server Team CI bot (server-team-bot) wrote on 2022-10-13:

PASSED: Continuous integration, rev:f24300f657a413c91be9c222478a0bb9498d380d
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/15/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/15//rebuild

review: Approve (continuous-integration)

Revision history for this message

Bryce Harrington (bryce) wrote on 2022-10-13:

"abbreviation" -> "abbreviations"

Grammatically three 'as' in the same sentence reads funny, but the comment is perfectly comprehensible. I might suggest changing the third 'as' to 'since'.

Otherwise LGTM, +1.

review: Approve

Revision history for this message

Robie Basak (racb) wrote on 2023-01-17:

Thanks! I've adopted all your suggestions. I also fixed a minor docstring omission I noticed. I'll just wait for CI to pass, then merge.

Revision history for this message

Server Team CI bot (server-team-bot) wrote on 2023-01-18:

PASSED: Continuous integration, rev:66cd050ce92c1a0960a22aae0336f0165a6e468c
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/16/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/16//rebuild