Merge ~racb/git-ubuntu:import-everything into git-ubuntu:main

Proposed by Robie Basak
Status: Merged
Approved by: Robie Basak
Approved revision: e6df75d071c7796581fce16a1aca510892eae4d6
Merged at revision: 41b3c36246d9c14c39919fb69c5a5fccce8b9ffe
Proposed branch: ~racb/git-ubuntu:import-everything
Merge into: git-ubuntu:main
Diff against target: 4770 lines (+3/-3211)
5 files modified
dev/null (+0/-2881)
gitubuntu/importer_service_poller.py (+2/-119)
gitubuntu/integration_test.py (+0/-28)
gitubuntu/scriptutils.py (+0/-182)
systemd/git-ubuntu-importer-service-poller.service (+1/-1)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Bryce Harrington Approve
Canonical Server Reporter Pending
Review via email: mp+431287@code.staging.launchpad.net

Commit message

Make Jenkins happy

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:7b8370b704211df0e117f155ef63a44278ec3c16
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/13/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/13//rebuild

review: Approve (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:e6df75d071c7796581fce16a1aca510892eae4d6
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/14/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/14//rebuild

review: Approve (continuous-integration)
Revision history for this message
Bryce Harrington (bryce) wrote :

Wow that's a huge deletion. The changes look sensible, and the tests still pass. LGTM, +1

review: Approve
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:41b3c36246d9c14c39919fb69c5a5fccce8b9ffe
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/17/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: VM Reset
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.canonical.com/server-team/job/git-ubuntu-ci/17//rebuild

review: Approve (continuous-integration)
Revision history for this message
Robie Basak (racb) wrote :

Thanks Bryce for the review!

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches