git-ubuntu

Merge ~racb/git-ubuntu:fix-reimport-tag-matching into git-ubuntu:master

  1. Git
  2. lp:~racb/git-ubuntu
  3. fix-reimport-tag-matching
  4. Merge into master
Proposed by Robie Basak
Status: Merged
Merged at revision: 95187cfe4376c5c6a0c6f375ea955a34ed31623f
Proposed branch: ~racb/git-ubuntu:fix-reimport-tag-matching
Merge into: git-ubuntu:master
Diff against target: 129 lines (+81/-1)
2 files modified
gitubuntu/git_repository.py (+56/-1)
gitubuntu/git_repository_test.py (+25/-0)
Reviewer Review Type Date Requested Status
Bryce Harrington Approve
Server Team CI bot continuous-integration Approve
Review via email: mp+390628@code.staging.launchpad.net

Commit message

Make Jenkins happy

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:95187cfe4376c5c6a0c6f375ea955a34ed31623f
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/541/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/541//rebuild

review: Approve (continuous-integration)
Revision history for this message
Bryce Harrington (bryce) wrote :

* 909d723: Adding a test case
  LGTM, +1
  Is there a LP # associated with this change? If so, maybe mention
  with this commit (e.g. in testcase docstring). If not, no worries.
* 4ff726d: Fixes mis-match
  LGTM, +1
* 95187cf: Adds docstrings
  Awesome, LGTM +1

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

I did not run the testsuite to verify the xfail and fix, but the fix looks obvious and the test implementation straightforward, so I trust if there were any issues the CI test would have caught them.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches