Merge ~racb/git-ubuntu:multiple-angle-brackets into git-ubuntu:master

Proposed by Robie Basak
Status: Merged
Merged at revision: fe87efa8257566c921025a13a0496148a4a185c7
Proposed branch: ~racb/git-ubuntu:multiple-angle-brackets
Merge into: git-ubuntu:master
Diff against target: 42 lines (+13/-1)
3 files modified
gitubuntu/changelog_tests/test_multiple_angle_brackets (+6/-0)
gitubuntu/git_repository.py (+1/-1)
gitubuntu/git_repository_test.py (+6/-0)
Reviewer Review Type Date Requested Status
Bryce Harrington Approve
Server Team CI bot continuous-integration Approve
Review via email: mp+388666@code.staging.launchpad.net

Commit message

Make Jenkins happy

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:1f3910275fa13eb30374228af64f190d7167de54
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/536/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/536//rebuild

review: Approve (continuous-integration)
Revision history for this message
Bryce Harrington (bryce) wrote :

LGTM, +1

## check.py
#!/usr/bin/python3
import re
maintainer = "Micah Anderson <email address hidden>>"
m = re.match(r'(?P<name>.*)<(?P<email>.*)>', maintainer)
print(m.group(1), m.group(2))
m = re.match(r'(?P<name>.*)<+(?P<email>.*?)>+', maintainer)
print(m.group(1), m.group(2))

# Output
$ python3 ./check.py
Micah Anderson <email address hidden>>
Micah Anderson <email address hidden>

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches