git-ubuntu

Merge ~racb/git-ubuntu:fix-remote-add-changelog-notes into git-ubuntu:master

  1. Git
  2. lp:~racb/git-ubuntu
  3. fix-remote-add-changelog-notes
  4. Merge into master
Proposed by Robie Basak
Status: Merged
Merged at revision: 9804f96758994b20f4cd1e5010c0390d768bef49
Proposed branch: ~racb/git-ubuntu:fix-remote-add-changelog-notes
Merge into: git-ubuntu:master
Diff against target: 133 lines (+65/-13)
1 file modified
gitubuntu/git_repository.py (+65/-13)
Reviewer Review Type Date Requested Status
Bryce Harrington Approve
Server Team CI bot continuous-integration Approve
Review via email: mp+383513@code.staging.launchpad.net

Commit message

Make Jenkins happy

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:30569f8934bd4b2dab2124889f64bdf626e2804b
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/510/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/510//rebuild

review: Approve (continuous-integration)
Revision history for this message
Bryce Harrington (bryce) wrote :

Looks good.

I might name the 'changelog_notes' parameter to 'has_changelog_notes' to better communicate that it's a bool rather than e.g. a list of notes or something. But this is internal and well documented so fine if you'd rather keep it as is. Either way, no need for another review round trip.

Otherwise, is a very straightforward fix, and very nice to see the additional code docs.

review: Approve
Revision history for this message
Robie Basak (racb) wrote :

Thank you for the review. I agree with the "has_changelog_notes" improvement, but I will avoid that for now to save another manual test cycle (as we have no automatic tests).

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches