git-ubuntu

Merge ~racb/git-ubuntu:clone-default-repository into git-ubuntu:master

  1. Git
  2. lp:~racb/git-ubuntu
  3. clone-default-repository
  4. Merge into master
Proposed by Robie Basak
Status: Merged
Merged at revision: edcfc90f6c29e896dffa48fe7f948d7c886312bd
Proposed branch: ~racb/git-ubuntu:clone-default-repository
Merge into: git-ubuntu:master
Diff against target: 49 lines (+26/-3)
1 file modified
gitubuntu/git_repository.py (+26/-3)
Reviewer Review Type Date Requested Status
Bryce Harrington Approve
Server Team CI bot continuous-integration Approve
Review via email: mp+383147@code.staging.launchpad.net

Commit message

Make Jenkins happy

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:9282fb6e4a9b3e57e45bc63821f6c546e6bc88ed
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/498/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/498//rebuild

review: Approve (continuous-integration)
Revision history for this message
Bryce Harrington (bryce) wrote :

Yep looks good.

Fwiw, I usually leave out the docs for the return value when there isn't one (as this is a pretty common situation), but I think it's fine listing it explicitly as None too.

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches