Merge ~racb/git-ubuntu:document-testing-strategy into git-ubuntu:master

Proposed by Robie Basak
Status: Merged
Merge reported by: Robie Basak
Merged at revision: 7ab1bb5dc734fd316a071d1ed5cd058aca413acf
Proposed branch: ~racb/git-ubuntu:document-testing-strategy
Merge into: git-ubuntu:master
Diff against target: 53 lines (+45/-0)
1 file modified
doc/STYLE.md (+45/-0)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Bryce Harrington Approve
Review via email: mp+383004@code.staging.launchpad.net

Commit message

Make Jenkins happy

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

FAILED: Continuous integration, rev:fb1bda2401f90482044060728acb70453144108f
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/496/
Executed test runs:
    FAILED: VM Setup

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/496//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:fb1bda2401f90482044060728acb70453144108f
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/497/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/497//rebuild

review: Approve (continuous-integration)
Revision history for this message
Robie Basak (racb) :
Revision history for this message
Bryce Harrington (bryce) wrote :

Looks good. I'm also curious to see how autospec can be leveraged for improved testing against external components. I've been experimenting with it a bit against Launchpad; no particular insights from this just yet, but it definitely seems to work as expected. But can leave all that to a future update of this document.

There are many ways to skin cats, and the factory pattern is one way to deal with the need for multiple fixtures but not the only way, and may not be the cleanest solution in all cases, but it's great to have it documented here for when it is the best way to achieve it.

All the text you've added is good. Footnotes with links to deeper information elsewhere would be handy, although given the likelihood of link rot, may as well just leave this to readers' google-fu.

I'm not certain that having this in the coding style guidelines is going to be the most discoverable place for it, although content-wise it seems an ok fit. More traditionally this would go into a HACKING.md type doc, although I think "development-process.md" might be a better name. Anyway, I guess can something to think about when the docs get reorganized someday.

review: Approve
Revision history for this message
Robie Basak (racb) wrote :

Agreed on all points - thanks!

Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:7ab1bb5dc734fd316a071d1ed5cd058aca413acf
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/505/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/505//rebuild

review: Approve (continuous-integration)

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches