Code review comment for ~quantifics/django-saml2-idp/+git/stable:py3

Revision history for this message
Jonathan Hartley (tartley) wrote :

Also, FYI, a rule of thumb is to try and keep MPs less than 500 lines (as measured here on this page, not by 'diff'). It isn't a hard requirement, we can always discuss whether it makes sense for a particular MP, but I have seen people request that a large, hard-to-review MP be split up before it can get approved. I'm not suggesting that you have to do it here, just bear it in mind.

Incidentally, just for my understanding, do you think adding the flake8 changes to this MP would generate lots more noise because the code wasn't flake8 compliant before this MP? Or would flake8 only modify the code that you have added/changed, so actually wouldn't increase this MPs linecount after all?

« Back to merge proposal