Code review comment for lp://staging/~pwlars/ubuntu-ci-services-itself/full-er-er-imagebuild-logging

Revision history for this message
Andy Doan (doanac) wrote :

On 03/05/2014 10:18 PM, Paul Larson wrote:
> One more thing I'd like to do is add some unit tests for run_worker as there are quite a few more paths through it now.

It might be worth considering creating some type of run_worker base
function/class that can be used for all the run workers that handles the
tricky parts of amqp_utils calls and unexcepted exceptions. Then we
could just write a test for that and let the actual run_workers focus on
handling domain-specific problems

« Back to merge proposal