Code review comment for lp://staging/~posulliv/oqgraph/drizzle-port

Revision history for this message
Padraig O'Sullivan (posulliv) wrote :

Hi!

I wanted to mess around with this engine and since I work mostly with drizzle, I ported it to drizzle. I thought I would submit the work I did to port the engine in case it is of any use to you guys.

I created a subdir named oqgraph that can simply be dropped in to the drizzle plugin directory. I also created a simple test suite for the engine that can be added under tests/suite in the drizzle tree.

I have a branch in drizzle for this work also:

lp:~posulliv/drizzle/oqgraph

If you check that branch out, you can just do the following:

$ ./config/autorun.sh && ./configure && make && make test

and it will automatically run the oqgraph test suite.

I removed the boost subdir for the drizzle port. For future work, I would need to make boost a compile time dependency for the plugin. I also need to investigate the usage of the bitmaps with this engine and make sure everything is ok here. Some weird assertion failures pop up with the read/write sets from time to time.

Anyway, feel free to use what I have done if you like. Let me know if it is of any use to you.

-Padraig

« Back to merge proposal