Code review comment for lp://staging/~pitti/lightdm/cleanup-session

Revision history for this message
Martin Pitt (pitti) wrote :

> Can we assume all processes are gone by the time TerminateSession() is called?

Not synchronously, it'll still take some time for the processes to react and shut down. But so far this seems to be "good enough" to fix the login issues.

But indeed this is a good point, this should be improved, like waiting for the session-XX.scope unit to actually disappear.

Thanks for adding a test!

« Back to merge proposal