Bileto

Merge lp://staging/~pitti/bileto/britney-logs into lp://staging/bileto

  1. britney-logs
  2. Merge into trunk
Proposed by Martin Pitt
Status: Merged
Merged at revision: 400
Proposed branch: lp://staging/~pitti/bileto/britney-logs
Merge into: lp://staging/bileto
Diff against target: 79 lines (+22/-16)
1 file modified
britney/iterate.py (+22/-16)
To merge this branch: bzr merge lp://staging/~pitti/bileto/britney-logs
Reviewer Review Type Date Requested Status
CU2D maintainers Pending
Review via email: mp+284792@code.staging.launchpad.net

Description of the change

Fix bug 1538717 and clean up some race conditions along the way; these are more apparent now that we want to keep previous log files.

To post a comment you must log in.
lp://staging/~pitti/bileto/britney-logs updated
399. By Ubuntu <email address hidden>

britney: Use per-run log files

 - Move to timestamped log files, instead of always writing to log.txt.
 - Move log file creation until after grabbing the lock, to avoid clobbering
   files from parallel britney runs.
 - Avoid needlessly copying the entire log file, just switch the last-run.txt
   symlink instead.
 - This fixes the race condition of copying last-run.txt after already
   releasing the lock, which could lead to corrupted log files.

400. By Ubuntu <email address hidden>

drop separate setup_log() function

401. By Ubuntu <email address hidden>

britney/iterate.py: Fix and simplifiy cleanup()

Call cleanup() via "finally:" instead of diverting and restoring sys.excepthook.
This also fixes a TypeError on calling cleanup() without arguments.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: