Code review comment for lp://staging/~phablet-team/network-manager/lp1445080
Revision history for this message
| Tony Espy (awe) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
2eb648a
demo site
(Get the code!)
Tested mako (rc/ubuntu #1) and started seeing off behavior while running the test cases:
https:/
Discovered a new NM crash file, and quickly found a bug. NMModem doesn't check for a value set_mm_enabled function before calling it, and this function was just removed from NMModemOfono as part of this change.
I just modified nm-modem-ofono.c to add a check for this function before invoking. Note, I opted to do this vs. re-add the function, as the function is essentially a no-op, as it's called when a Killswitch signal is received from URfkill for the modem. At the point the signal is received, there's really nothing else remaining to be done, other than wait for the modem state to settle ( which is handled by NMModemOfono ).