Media Hub

Merge lp://staging/~phablet-team/media-hub/bg-playlist-fixes into lp://staging/media-hub/stable

  1. bg-playlist-fixes
  2. Merge into stable
Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Jim Hodapp
Approved revision: 168
Merged at revision: 163
Proposed branch: lp://staging/~phablet-team/media-hub/bg-playlist-fixes
Merge into: lp://staging/media-hub/stable
Prerequisite: lp://staging/~morphis/media-hub/previous-to-same-after-four-secs
Diff against target: 703 lines (+237/-42)
11 files modified
include/core/media/track_list.h (+8/-0)
src/core/media/mpris/service.h (+12/-0)
src/core/media/mpris/track_list.h (+17/-0)
src/core/media/player_implementation.cpp (+12/-0)
src/core/media/service_skeleton.cpp (+22/-6)
src/core/media/track_list.cpp (+5/-0)
src/core/media/track_list_implementation.cpp (+25/-18)
src/core/media/track_list_skeleton.cpp (+102/-16)
src/core/media/track_list_skeleton.h (+4/-0)
src/core/media/track_list_stub.cpp (+29/-2)
src/core/media/track_list_stub.h (+1/-0)
To merge this branch: bzr merge lp://staging/~phablet-team/media-hub/bg-playlist-fixes
Reviewer Review Type Date Requested Status
Jim Hodapp (community) code Approve
Review via email: mp+276094@code.staging.launchpad.net

Commit message

Make sure our iterator for the current track points to the right place when (un)shuffling (LP #1510219). Fix crash when client tries to set the player for a non-existing key. Do not add empty URIs to the list (LP: #1511029).

Description of the change

Make sure our iterator for the current track points to the right place when (un)shuffling (LP #1510219). Fix crash when client tries to set the player for a non-existing key. Do not add empty URIs to the list (LP: #1511029).

To post a comment you must log in.
lp://staging/~phablet-team/media-hub/bg-playlist-fixes updated
165. By Alfonso Sanchez-Beato

Do not add empty URIs to the list (LP: #1511029)

166. By Alfonso Sanchez-Beato

Send TrackChanged signals only when the TrackAdded signal for the
corresponding track has already been sent.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

A few comments inline.

review: Needs Fixing (code)
lp://staging/~phablet-team/media-hub/bg-playlist-fixes updated
167. By Alfonso Sanchez-Beato

Address review comments

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Branch refreshed after addressing comments.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks good, one minor change still needed.

review: Needs Fixing
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Branch refreshed after addressing comment.

lp://staging/~phablet-team/media-hub/bg-playlist-fixes updated
168. By Alfonso Sanchez-Beato

Address review comment

Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve (code)
lp://staging/~phablet-team/media-hub/bg-playlist-fixes updated
169. By Alfonso Sanchez-Beato

Repeat current track when already played more than five seconds

170. By Alfonso Sanchez-Beato

Fix for the repeat track feature

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

lp:~morphis/media-hub/previous-to-same-after-four-secs merged + fix for it

lp://staging/~phablet-team/media-hub/bg-playlist-fixes updated
171. By Alfonso Sanchez-Beato

Add TrackListReset signal, which is emitted when the Reset DBus method is
called.

172. By Alfonso Sanchez-Beato

Update properly playlist iterator when adding or removing tracks
(LP: #1511073).

173. By Alfonso Sanchez-Beato

Use get/set_current track when shuffling

174. By Alfonso Sanchez-Beato

Force index update when changing the track list

Revision history for this message
Jim Hodapp (jhodapp) wrote :

A few comments below about the latest changes.

review: Needs Fixing
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Some comments answered. I will update the branch later as I will modify qtubuntu-media too.

lp://staging/~phablet-team/media-hub/bg-playlist-fixes updated
175. By Alfonso Sanchez-Beato

Address review comments

Revision history for this message
Jim Hodapp (jhodapp) wrote :

Several comments inline below.

review: Needs Fixing (code)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

See comments below. I will address the remaining issues asap.

lp://staging/~phablet-team/media-hub/bg-playlist-fixes updated
176. By Alfonso Sanchez-Beato

Address review comments

Revision history for this message
Jim Hodapp (jhodapp) wrote :

A couple of comments below.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: