Code review comment for lp://staging/~pfalcon/linaro-android-build-tools/descr-update
Revision history for this message
| Paul Sokolovsky (pfalcon) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
70fb091
demo site
(Get the code!)
> While I am not a fan of the pink
Well, the idea is to get attention. At least it's not red ;-).
> My preference would be to use a heading and define CSS for it to set the "New!" bit up as a different colour. That said, it is in a big colourful box - it is going to get peoples attention - so I think the new is not required and I would just delete it.
Well, it does use CSS to define colors. Do you mean to use styles? If so, the need to define styles all the time (essentially, an extra level of indirection) is overstated. There're cases where self-containment and clarity is more important, and arguably this is the case.
And for "New!", well, it is! I probably wouldn't add it though if we didn't have what we have on the frontpage. But well, let's be user-friendly ;-). The idea is to remove "new!" in a couple of months and let just the box hang. (I don't even dream of actually having better formatted/consisted build descriptions).