Merge lp://staging/~pete-woods/net-cpp/uri-builder into lp://staging/net-cpp

Thanks for getting started on this. I have a few comments:

(1.) I would propose to have a

struct Uri
{
struct Endpoint
{
};

struct Parameters
{
};
};

Where Endpoint and Parameters could just be appropriate typedefs. We could put it into core/net/uri.h, being ready for consumption by core/net/http/client.h.

(2.) We should provide a default implementation of build_uri, that can be reused by any implementation that provides implementations for url_escape.

(3.) There are some manual uri setups in the test-cases. I would appreciate it if you could change those to leverage the new interface.

Before I go changing the rest of the test suite, is this more what you wanted?

> Before I go changing the rest of the test suite, is this more what you wanted?

Yes, that matches my mental model :) thanks.

Hmm, just started looking at this, and the httpbin paths aren't really in a useful form for this.

i.e. they provide:

base = "http://127.0.0.1:5000"
path = "/get/banana"

To put these in a useful form for the API, I'd first have to split them into their components, then pass those into the URI builder. Seems like a lot of effort to go through.

If I just ran them through like this:
    net::make_uri(httpbin::host, {httpbin::resources::get()})
then it will URI escape the slash characters, which is not what we want at all.

The alternative would be to do this:
    net::make_uri(httpbin::host + httpbin::resources::get())
but I'm not sure if that's any better than just using a string?

Fair point, let's leave the httpbin tests as they are then.

Hopefully I should have addressed your remaining concerns now. :)

Okay, I've renamed the URI components to host, path, and query_parameters now.

LGTM, thanks for the changes.