Thanks for getting started on this. I have a few comments:
(1.) I would propose to have a
struct Uri
{
struct Endpoint
{
};
struct Parameters
{
};
};
Where Endpoint and Parameters could just be appropriate typedefs. We could put it into core/net/uri.h, being ready for consumption by core/net/http/client.h.
(2.) We should provide a default implementation of build_uri, that can be reused by any implementation that provides implementations for url_escape.
(3.) There are some manual uri setups in the test-cases. I would appreciate it if you could change those to leverage the new interface.
Thanks for getting started on this. I have a few comments:
(1.) I would propose to have a
struct Uri
{
struct Endpoint
{
};
struct Parameters
{
};
};
Where Endpoint and Parameters could just be appropriate typedefs. We could put it into core/net/uri.h, being ready for consumption by core/net/ http/client. h.
(2.) We should provide a default implementation of build_uri, that can be reused by any implementation that provides implementations for url_escape.
(3.) There are some manual uri setups in the test-cases. I would appreciate it if you could change those to leverage the new interface.