Code review comment for lp://staging/~pete-woods/libusermetrics/cmake-extras-compatibility

Revision history for this message
James Henstridge (jamesh) wrote :

Does the coverage report still work with this change?

The cmake/Coverage.cmake file looks like it will unconditionally add the coverage rules if CMAKE_BUILD_TYPE=coverage once it is included.

With find_package(CoverageReport), it is also necessary to call enable_coverage_report(), telling it about the coverage targets, test targets, and directories to exclude from the report.

review: Needs Information

« Back to merge proposal