Merge lp://staging/~pedronis/go-dbus/fix-names-races-n-hangs into lp://staging/go-dbus/v1
Proposed by
Samuele Pedroni
| Status: | Merged |
|---|---|
| Merged at revision: | 130 |
| Proposed branch: | lp://staging/~pedronis/go-dbus/fix-names-races-n-hangs |
| Merge into: | lp://staging/go-dbus/v1 |
| Diff against target: |
495 lines (+140/-114) 5 files modified
dbus_test.go (+8/-5) decoder_test.go (+27/-27) names.go (+98/-75) names_test.go (+6/-6) types.go (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~pedronis/go-dbus/fix-names-races-n-hangs |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| John Lenton | Approve | ||
|
Review via email:
|
|||
Description of the change
fix races and test hangs in names.go,
either adding locks or making sure watches are setup first thing
(includes also a round of go fmt fixes in other files)
To post a comment you must log in.
Revision history for this message
| Samuele Pedroni (pedronis) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
running tests repeatedly there should be now just a hang in signal_test sometines, and with -race there should be just one race reported also in signal.go, these are going to be addressed in the next branch