Code review comment for lp://staging/~parthm/bzr/571467-ci-show-diff-short-opt-p

Revision history for this message
Parth Malwankar (parthm) wrote :

> I had to read the bug to figure out why "-p" (it's short for "patch"). It'd
> be nice to explain that somewhere, but I don't know where would be
> appropriate. Anyway, this seems fine.

bzr log is somewhat clear on this:
-p, --show-diff Show changes made in each revision as a patch.

For bzr ci its:
-p, --show-diff When no message is supplied, show the diff along with
                      the status summary in the message editor.

John suggested for another proposal[1] that --null can be pulled into
bzrlib.option.
Maybe we should do something similar for --show-diff/-p?
-p, --show-diff Show changes made in the revision as a patch.

The help message won't be as specific but then the options go together.

[1] https://code.launchpad.net/~parthm/bzr/181124-ls-short-opts/+merge/24414

« Back to merge proposal