Code review comment for lp://staging/~parthm/bzr/503670-grep-plugin

Thanks for reviewing the code.

> Think I prefer the other version, trying to recreate grep in python seems a
> little daft.
>

Having a plugin would allow us to have good support for history and view.
Some users might be able to use 'bzr ls [opts] | grep' to achieve the
same results but that would require grep installed on windows (not very common) and we
would end up with bug #503670 :-)

IMO haveing grep built on bzrlib API is a better approach. hg and git seem to do the
same as they also provide features like searching history. This would allow
us to provide similar features and possibly more in the future.

> Misses `-r --include=*.py` which is one of my more commonly used set of
> arguments.

Thanks for pointing out the use case.
If the general approach of the plugin seems ok (API used, any oversights etc.)
to to those more familiar with internals than me I hope to enhance it to add
views and history support along with more options over time.