Code review comment for lp://staging/~osomon/oxide/maxCacheSize

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

This looks mostly ok - I just have one small comment on the API. Could we make the unit for WebContext.maxCacheSizeHint MB instead of bytes? The initial cache size is about 1MB when it's created anyway, and given that this is not a hard limit I don't think it makes sense to create an illusion that applications can control the cache size to the nearest byte.

Other than that, it looks fine.

review: Approve

« Back to merge proposal