Grail

Merge lp://staging/~oif-team/grail/trunk.touch into lp://staging/grail

  1. trunk.touch
  2. Merge into trunk
Proposed by Henrik Rydberg
Status: Merged
Merged at revision: 138
Proposed branch: lp://staging/~oif-team/grail/trunk.touch
Merge into: lp://staging/grail
Diff against target: 482 lines (+202/-35)
12 files modified
include/grail-types.h (+28/-0)
src/Makefile.am (+1/-0)
src/gestures-drag.c (+4/-8)
src/gestures-pinch.c (+2/-6)
src/gestures-rotate.c (+2/-6)
src/gestures-touch.c (+94/-0)
src/grail-gestures.c (+6/-7)
src/grail-gestures.h (+4/-0)
src/grail-inserter.c (+53/-8)
src/grail-inserter.h (+4/-0)
src/grail-recognizer.c (+2/-0)
src/grail-recognizer.h (+2/-0)
To merge this branch: bzr merge lp://staging/~oif-team/grail/trunk.touch
Reviewer Review Type Date Requested Status
Stephen M. Webb Pending
Chase Douglas Pending
Review via email: mp+55225@code.staging.launchpad.net

This proposal supersedes a proposal from 2011-03-28.

Description of the change

This patchset introduces gesture touch events.

To post a comment you must log in.
Revision history for this message
Chase Douglas (chasedouglas) wrote : Posted in a previous version of this proposal

I'm guessing the functionality is correct, but the header file is missing the TOUCH event attributes (just like there are separate DRAG, PINCH, ROTATE, etc. attributes).

review: Needs Fixing
Revision history for this message
Henrik Rydberg (rydberg) wrote : Posted in a previous version of this proposal

Seems like a mid-air collision - it seems they are present now.

Revision history for this message
Henrik Rydberg (rydberg) wrote : Posted in a previous version of this proposal

Removed a stale variable and fixed one whitespace error, looks all good to me now.

Revision history for this message
Chase Douglas (chasedouglas) wrote : Posted in a previous version of this proposal

In the grail-types.h file there's an old comment that should be removed:

+/* touch event types use drag properties */

I now seem unable to trigger any non-touch gestures when a touch gesture is performed, though...

review: Needs Fixing
Revision history for this message
Stephen M. Webb (bregma) wrote : Posted in a previous version of this proposal

The code looks OK stylistically and seems to work as I expected through geistest (once installed correctly). I do not have a problem with this.

review: Approve
Revision history for this message
Henrik Rydberg (rydberg) wrote : Posted in a previous version of this proposal

There were some confusion as to what was a bug and what was expected behavior, but hopefully that is all straightened out now. This version seem to solve the known issues. Also see 744391 for another bugfix that goes on top of these.

Revision history for this message
Chase Douglas (chasedouglas) wrote : Posted in a previous version of this proposal

Still has the touch types comment that should be removed :).

review: Needs Fixing
Revision history for this message
Chase Douglas (chasedouglas) wrote : Posted in a previous version of this proposal

All my comments have been addressed, and it appears to be working properly through gesturetest and geistest (with the new and improved utouch-geis :).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: