Grail

Merge lp://staging/~oif-team/grail/trunk.touch into lp://staging/grail

  1. trunk.touch
  2. Merge into trunk
Proposed by Henrik Rydberg
Status: Superseded
Proposed branch: lp://staging/~oif-team/grail/trunk.touch
Merge into: lp://staging/grail
Diff against target: 454 lines (+194/-29)
12 files modified
include/grail-types.h (+29/-0)
src/Makefile.am (+1/-0)
src/gestures-drag.c (+4/-8)
src/gestures-pinch.c (+2/-6)
src/gestures-rotate.c (+2/-6)
src/gestures-touch.c (+94/-0)
src/grail-gestures.c (+6/-7)
src/grail-gestures.h (+4/-0)
src/grail-inserter.c (+45/-2)
src/grail-inserter.h (+3/-0)
src/grail-recognizer.c (+2/-0)
src/grail-recognizer.h (+2/-0)
To merge this branch: bzr merge lp://staging/~oif-team/grail/trunk.touch
Reviewer Review Type Date Requested Status
Open Input Framework Team Pending
Review via email: mp+54930@code.staging.launchpad.net

This proposal supersedes a proposal from 2011-03-25.

This proposal has been superseded by a proposal from 2011-03-26.

Description of the change

This patchset introduces gesture touch events.

To post a comment you must log in.
Revision history for this message
Chase Douglas (chasedouglas) wrote : Posted in a previous version of this proposal

I'm guessing the functionality is correct, but the header file is missing the TOUCH event attributes (just like there are separate DRAG, PINCH, ROTATE, etc. attributes).

review: Needs Fixing
Revision history for this message
Henrik Rydberg (rydberg) wrote :

Seems like a mid-air collision - it seems they are present now.

lp://staging/~oif-team/grail/trunk.touch updated
133. By Henrik Rydberg

Introduce touch gesture events

Touch gesture events follow the same logic as drags, except they
cannot be held back but are emitted immediately.

Signed-off-by: Henrik Rydberg <email address hidden>

134. By Henrik Rydberg

Decouple timeout from discard

Move the actual gesture discard from the recognition phase
to the instantiation phase.

Signed-off-by: Henrik Rydberg <email address hidden>

135. By Henrik Rydberg

Do not timeout gestures overlapping touch gestures

The notion of listening to touch gestures implies that the
touches of those gestures never timeout. Hence, any pending
gesture that overlaps those touches should not timeout.

Signed-off-by: Henrik Rydberg <email address hidden>

136. By Henrik Rydberg

Never active gestures below activation threshold

Currently, all gestures activate after a certain time, such that
the smallest change result in gesture events. This was designed
to minimize disruption in pointer movement. Since grail no longer
handles pointers, the logic can be simplified to only activate when
the threshold is reached.

Signed-off-by: Henrik Rydberg <email address hidden>

137. By Henrik Rydberg

Do not treat single finger activation differently

Single-finger drags should no longer behave differently from
any other drag gesture. Fixed with this patch.

Signed-off-by: Henrik Rydberg <email address hidden>

138. By Henrik Rydberg

Do not hold back active gestures

Gestures that has once been sent should never be held back. The
current code would under some circumstance hold the gesture end
event and later discard it. This oneliner solves the problem, which
has been around since 241c5ec, Aug 2010. LP: #744391.

Signed-off-by: Henrik Rydberg <email address hidden>

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: