Code review comment for lp://staging/~oif-team/grail/pivot-disambiguation
Revision history for this message
| Jussi Pakkanen (jpakkane) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
2eb648a
demo site
(Get the code!)
Lots of code removed. That's always good.
You change the header so this is clearly an API break. I assume that library versions have already been incremented since last release?
Detection against div by zero is done with this: if (div == 0). However floats seldom go to zero due to rounding errors. Maybe something like 'if abs(div) < SOME_THRESHOLD_
Does the struct now have all info needed for Grip transformations? It would seem to me that these would be rotation_center and center are the transformation center points. Is this correct?