Geis

Merge lp://staging/~oif-team/geis/geis2-add-filters into lp://staging/geis

  1. geis2-add-filters
  2. Merge into trunk
Proposed by Stephen M. Webb
Status: Merged
Merged at revision: 100
Proposed branch: lp://staging/~oif-team/geis/geis2-add-filters
Merge into: lp://staging/geis
Diff against target: 2455 lines (+1784/-68)
28 files modified
.bzrignore (+2/-2)
ChangeLog (+150/-0)
configure.ac (+1/-0)
include/geis/geis.h (+69/-2)
libutouch-geis/Makefile.am (+3/-1)
libutouch-geis/backend/Makefile.am (+1/-1)
libutouch-geis/backend/test_fixture/Makefile.am (+22/-0)
libutouch-geis/backend/test_fixture/geis_backend_test_fixture.c (+45/-3)
libutouch-geis/backend/test_fixture/geis_backend_test_fixture.h (+5/-3)
libutouch-geis/geis.c (+133/-22)
libutouch-geis/geis_attr.c (+23/-1)
libutouch-geis/geis_device.c (+16/-7)
libutouch-geis/geis_filter.c (+456/-0)
libutouch-geis/geis_filter.h (+123/-0)
libutouch-geis/geis_filter_term.c (+206/-0)
libutouch-geis/geis_filter_term.h (+139/-0)
libutouch-geis/geis_private.h (+16/-1)
libutouch-geis/geis_subscription.c (+88/-22)
libutouch-geis/geis_subscription.h (+22/-1)
libutouch-geis/libutouch-geis.ver (+9/-0)
testsuite/geis2/Makefile.am (+1/-0)
testsuite/geis2/check_device.c (+41/-1)
testsuite/geis2/check_filter.c (+41/-0)
testsuite/geis2/check_geis2_api.c (+2/-0)
testsuite/geis2/check_subscription.c (+66/-1)
testsuite/libutouch-geis/Makefile.am (+1/-0)
testsuite/libutouch-geis/check_filter.c (+101/-0)
testsuite/libutouch-geis/check_geis2_internals.c (+2/-0)
To merge this branch: bzr merge lp://staging/~oif-team/geis/geis2-add-filters
Reviewer Review Type Date Requested Status
Henrik Rydberg (community) Approve
Chase Douglas Pending
Review via email: mp+45318@code.staging.launchpad.net

This proposal supersedes a proposal from 2011-01-04.

Description of the change

GEIS v2.0 filter API

All changes requested by Henrik have been made.

As I warned on IRC, implementing the _get_attr_for_factility() was nontrivial (in fact I renamed it). Additional test cases and resulting bug fixes were added.

This respin completes the filter and subscription API for devices. The filter and subscription API for gesture classes will have to wait until after the gesture class module is merged.

To post a comment you must log in.
Revision history for this message
Henrik Rydberg (rydberg) wrote : Posted in a previous version of this proposal

At geis.h:132, there is a "teh".

In geis_filter_term_bag_new(), there is an error path that returns non-null.

That's about what I could find. Perhaps also adding _get_attr_for_factility() before respinning this patch would be good.

review: Needs Fixing
Revision history for this message
Chase Douglas (chasedouglas) wrote : Posted in a previous version of this proposal

Seems reasonable to me from a high-level perspective. I'm not going to go into a line-level code review, so I'm approving.

We still need to figure out continuations in this filter framework, but we'll do so next week at the rally.

review: Approve
Revision history for this message
Henrik Rydberg (rydberg) wrote :

Some duplication of code in geis_filter_add_term() that could be removed at some point, but looks fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: