Code review comment for lp://staging/~oif-team/geis/geis2-add-filters

Revision history for this message
Henrik Rydberg (rydberg) wrote :

At geis.h:132, there is a "teh".

In geis_filter_term_bag_new(), there is an error path that returns non-null.

That's about what I could find. Perhaps also adding _get_attr_for_factility() before respinning this patch would be good.

review: Needs Fixing

« Back to merge proposal