Code review comment for lp://staging/~oif-team/geis/event-control-functions

Revision history for this message
Stephen M. Webb (bregma) wrote :

> There is a geis_event_attr_by_name(), but is there a way to retrieve the index corresponding to
> the name?

No, the GeisEvent is effectively an associative container of attributes and I am not aware of any associative container that provides such functionality. Is there a use case you're thinking of?

> It would be good if the geis_event_queue_dequeue() docs state who owns the pointer after the call,
> and/or for how long the pointer is valid.

OK, I updated the docs to try to explain that the container uses value semantics on the opaque objects and does not control use of those object either before or after their being contained.

« Back to merge proposal