Code review comment for lp://staging/~nuclearbob/qa-dashboard/categories

On Thu, Jan 16, 2014 at 06:06:29PM -0000, Max Brustkern wrote:
> === modified file 'smokeng/views.py'
> --- smokeng/views.py 2013-11-21 16:58:17 +0000
> +++ smokeng/views.py 2014-01-16 18:04:46 +0000
> @@ -17,6 +17,7 @@
> import re
>
> from django.db import models
> +from django.forms.models import modelform_factory
> from django.shortcuts import (
> render_to_response,
> get_object_or_404,
> @@ -298,6 +299,7 @@
> 'summary': summary,
> 'build_number': image.build_number,
> 'release': release,
> + 'categories': image.categories(),
> 'table': table,
> 'bread_crumb_trail': BreadCrumbTrail.leading_to(
> image_overview,
> @@ -417,6 +419,7 @@
> 'totals': totals,
> 'jenkins_url': jenkins_url,
> 'private_url': private_url,
> + 'categories': result.categories(),
> 'table': table,
> 'artifacts': artifacts,
> 'history': _test_history(result),
> @@ -468,7 +471,6 @@
> 'id',
> ],
> )
> -@require_GET

I think this should be:

@require_http_methods(["GET", "POST"])

Make sure to import it along with require_GET.

Other than that I think it looks fine.

Joe