Code review comment for lp://staging/~nuclearbob/qa-dashboard/categories

On Tue, Jan 07, 2014 at 04:29:23PM -0000, Max Brustkern wrote:
> > review needs-fixing
> >
> > The first thing I noticed is no tests. :-(
> I think I have the implementation in better shape now, so I'll re-propose the merge with tests once they're ready.
> >
> > The second thing I noticed, @properties are bad.. :-)
> Should I just remove the decorator and have these as functions?

@properties aren't bad in general only those that access the db. It
perfectly acceptable to do something like this.

@property
def display_name(self):
    return "{} {}".format(self.first_name, self.last_name)