Code review comment for lp://staging/~nuclearbob/autopilot/bug1210260

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

Hi,

This looks great - with one teensy exception - please change these:

 :raises: ValueError if more than one class in the dict matches

to be:

 :raises ValueError: if more than one class in the dict matches

i.e.- as we discussed in the PEP257 thread.

After that's done, I'm happy to merge it.

Cheers

« Back to merge proposal