Merge lp://staging/~nmb/bzr/fix-213184 into lp://staging/bzr

Proposed by Neil Martinsen-Burrell
Status: Merged
Approved by: John A Meinel
Approved revision: not available
Merged at revision: not available
Proposed branch: lp://staging/~nmb/bzr/fix-213184
Merge into: lp://staging/bzr
Diff against target: 70 lines (+26/-5)
2 files modified
bzrlib/conflicts.py (+3/-5)
bzrlib/help_topics/en/conflicts.txt (+23/-0)
To merge this branch: bzr merge lp://staging/~nmb/bzr/fix-213184
Reviewer Review Type Date Requested Status
John A Meinel Approve
Robert Collins (community) Approve
Review via email: mp+15158@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Neil Martinsen-Burrell (nmb) wrote :

This adds documentation about fixing tag conflicts to bzr help conflicts. It should take a step towards fixing 213184. I did not add a mention of this to ``bzr pull`` since I think that ``bzr help conflicts`` is a reasonable response to "Conflicting tags", but I could add that if desired.

Revision history for this message
Robert Collins (lifeless) wrote :

Looks good. Perhaps it should say 'apply the tag you want to win to one of the branches - either the source or target.'. Also, pull --overwrite will overwrite all tags, I think.

review: Approve
Revision history for this message
Neil Martinsen-Burrell (nmb) wrote :

Updated in that branch.

Revision history for this message
John A Meinel (jameinel) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bzrlib/conflicts.py'
--- bzrlib/conflicts.py 2009-03-23 14:59:43 +0000
+++ bzrlib/conflicts.py 2009-11-25 16:45:24 +0000
@@ -53,13 +53,12 @@
53 instead. (This is useful for editing all files with text conflicts.)53 instead. (This is useful for editing all files with text conflicts.)
5454
55 Use bzr resolve when you have fixed a problem.55 Use bzr resolve when you have fixed a problem.
56
57 See also bzr resolve.
58 """56 """
59 takes_options = [57 takes_options = [
60 Option('text',58 Option('text',
61 help='List paths of files with text conflicts.'),59 help='List paths of files with text conflicts.'),
62 ]60 ]
61 _see_also = ['resolve']
6362
64 def run(self, text=False):63 def run(self, text=False):
65 from bzrlib.workingtree import WorkingTree64 from bzrlib.workingtree import WorkingTree
@@ -82,16 +81,15 @@
82 before you should commit.81 before you should commit.
8382
84 Once you have fixed a problem, use "bzr resolve" to automatically mark83 Once you have fixed a problem, use "bzr resolve" to automatically mark
85 text conflicts as fixed, resolve FILE to mark a specific conflict as84 text conflicts as fixed, "bzr resolve FILE" to mark a specific conflict as
86 resolved, or "bzr resolve --all" to mark all conflicts as resolved.85 resolved, or "bzr resolve --all" to mark all conflicts as resolved.
87
88 See also bzr conflicts.
89 """86 """
90 aliases = ['resolved']87 aliases = ['resolved']
91 takes_args = ['file*']88 takes_args = ['file*']
92 takes_options = [89 takes_options = [
93 Option('all', help='Resolve all conflicts in this tree.'),90 Option('all', help='Resolve all conflicts in this tree.'),
94 ]91 ]
92 _see_also = ['conflicts']
95 def run(self, file_list=None, all=False):93 def run(self, file_list=None, all=False):
96 from bzrlib.workingtree import WorkingTree94 from bzrlib.workingtree import WorkingTree
97 if all:95 if all:
9896
=== modified file 'bzrlib/help_topics/en/conflicts.txt'
--- bzrlib/help_topics/en/conflicts.txt 2007-12-25 04:17:50 +0000
+++ bzrlib/help_topics/en/conflicts.txt 2009-11-25 16:45:24 +0000
@@ -79,6 +79,29 @@
79FILE". Bazaar cannot auto-detect when conflicts of this kind have been79FILE". Bazaar cannot auto-detect when conflicts of this kind have been
80resolved.80resolved.
8181
82Tag conflicts
83-------------
84
85Typical message::
86
87 Conflicting tags:
88 version-0.1
89
90When pulling from or pushing to another branch, Bazaar informs you about tags
91that conflict between the two branches; that is the same tag points to two
92different revisions. You need not resolve these conflicts, but subsequent
93uses of pull or push will result in the same message.
94
95To resolve the conflict, you must apply the correct tags to either the target
96branch or the source branch as appropriate. Use "bzr tags --show-ids -d
97SOURCE_URL" to see the tags in the source branch. If you want to make the
98target branch's tags match the source branch, then in the target branch do
99``bzr tag --force -r revid:REVISION_ID CONFLICTING_TAG`` for each of the
100CONFLICTING_TAGs, where REVISION_ID comes from the list of tags in the source
101branch. You need not call "bzr resolve" after doing this. To resolve in favor of the target branch, you need to similarly use ``tag --force`` in the source
102branch. (Note that pulling or pushing using --overwrite will overwrite all
103tags as well.)
104
82Duplicate paths105Duplicate paths
83---------------106---------------
84107