Code review comment for lp://staging/~nmb/bzr-keywords/after-2.6

Revision history for this message
Neil Martinsen-Burrell (nmb) wrote :

Yes, r20 of bzr-keywords broke compatibility with versions of bzr that
don't have r6498.5.1 (merged in r6517):

nmb@garble[~/src/bzr/bzr.all]$ bzr revert -r tag:bzr-2.5.1
[...]
nmb@garble[~/src/bzr/bzr.all]$ ./bzr selftest -s bp.keywords
'module' object has no attribute 'filter_stacks_registry'
----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

This came up on the mailing list recently and reverting to r19 fixed
the problem on bzr 2.5.0.

On Fri, Jul 20, 2012 at 8:01 AM, Jelmer Vernooij
<email address hidden> wrote:
> Couldn't we just support both? Did one of my recent changes break compatibility with older versions of bzr?
> --
> https://code.launchpad.net/~nmb/bzr-keywords/after-2.6/+merge/115257
> You are the owner of lp:~nmb/bzr-keywords/after-2.6.

« Back to merge proposal