Code review comment for lp://staging/~nikwen/account-polld/more-flexible-account-authentication

Revision history for this message
Alberto Mardegan (mardy) wrote :

Hi Niklas, this is very good work, thanks! :-)

I've written a few inline comments, please have a look at them. As a general remark, I can say that the code looks very good (though I wonder, is there a better way to pass the Data to the Go module, without having the two arrays of keys and values being passed separately? Is it possible to construct the Go dictionary in C?), but I believe that you haven't tested it with Twitter, because -- just by looking at the code, so I might be wrong -- it seems to me that the changes must have broken it.

Once you fix the various issues, could you please also test the Twitter integration and make sure that it continues working?

review: Needs Fixing

« Back to merge proposal