Code review comment for lp://staging/~niemeyer/lbox/long-summary

Revision history for this message
Martin Packman (gz) wrote :

Thanks. Looks alright to my limited knowledge of the language (spell
while loops with 'for' huh?)

The different handling of long subject vs. no subject seems like a minor
wrinkle. Looping on Log validity instead might be neater, provided it is
still escapable. Giving a hint of how long might be nice, rather than
leaving it to trial and error for the user. (With git review I noticed I
get some vim highlight thing that changes colour at 50 characters, but
that's not in scope here.)

https://codereview.appspot.com/6302100/

« Back to merge proposal