Code review comment for lp://staging/~niedbalski/charms/precise/rsyslog/lp-1310793

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Hi Jorge,

In addition to the one line fix that Tim mentioned, make lint is also failing with a few flake8 errors:

$ make lint
hooks/hooks.py:5:1: F401 're' imported but unused
hooks/hooks.py:54:9: F401 'jinja2' imported but unused
make: *** [lint] Error 1

Could you address those as well prior to merging, otherwise another +1 from me, amazing work!

« Back to merge proposal