Code review comment for lp://staging/~nicolariolini/account-invoicing/add_module_account_payment_term_month

Revision history for this message
Lorenzo Battistini (elbati) wrote :

On 06/04/2014 08:18 AM, Sergio Corato wrote:
> In everyway, I overwritten the function (instead of overriden) and cover
> the case of 'days' too (for other purposes).
>
>
> 2014-06-04 8:12 GMT+02:00 Sergio Corato <email address hidden>:
>
>> Ciao Lorenzo,
>> they aren't mutually exclusive, in this way only one of them is needed.
>> But it would be better to set field days invisibile if months are set.

I mean, if one field is used, the other one should not be used. If the
user can fill both, it can create confusion.

What problem do you see with keeping the 'commercial_month' field? It
seems useable to me.

« Back to merge proposal