Code review comment for lp://staging/~nick-dedekind/unity8/sidestage-restoreOnRotation

Revision history for this message
Michael Zanetti (mzanetti) wrote :

I'm with nick on this one. It's ok to use WindowStateStorage as a storage during runtime too. If the syncing to disk is the issue here (which I'm not really sure if it is, because it's not that we're hitting the flash really often) then yes, the WindowStateStorage component should be changed to only sync later or something. I however would probably vote to sync all the time because this way it saves the user's preferences even when something crashes.

« Back to merge proposal