Code review comment for lp://staging/~nick-dedekind/unity8/sidestage-restoreOnRotation

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Nice refactoring in tst_TabletStage.

-----------

This sure is the easiest way to fix that bug, but I think it's wasteful to keep updating a database on disk (IO) about information you already keep in a variable in RAM. You only need to write that info to disk once the application goes away, as you are no longer keeping tabs on it in RAM.

Why does it lose that information when you rotate the shell?

What will happen if an application has two surfaces (one in main and one in side stage) and you rotate to portrait and then back to landscape (tst_OrientedShell doesn't have yet those app list controls so I could easily reproduce this use case)?

review: Needs Information

« Back to merge proposal